You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In c7c0901, I attempted to unbreak AbortSignal but didn't do a great job (oops).
Anne gave me some private feedback:
misses an equal sign at the end
Also, it seems the spec still uses AbortError unconditionally, the other change that's needed is to use signal's abort reason instead
I'll try to send in a PR today/tomorrow.
The text was updated successfully, but these errors were encountered:
Please fix the missing equals sign, but I don't think we want to use the abort reason unless there's a way to encapsulate it in an AbortError. Using the abort reason will mean that the Promises reject with "undefined" by default which is a rather confusing developer experience.
In c7c0901, I attempted to unbreak AbortSignal but didn't do a great job (oops).
Anne gave me some private feedback:
I'll try to send in a PR today/tomorrow.
The text was updated successfully, but these errors were encountered: