Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make h_indirect more efficient #90

Open
jbangert opened this issue Jan 15, 2014 · 1 comment
Open

Make h_indirect more efficient #90

jbangert opened this issue Jan 15, 2014 · 1 comment

Comments

@jbangert
Copy link

As far as I see it, the current mechanism for h_indirect introduces one unneeded function call. Why not copy the contents of HParser in h_bind_indirect (and therefore the vtable)? This removes the need for the proxy design pattern currently in use. Maybe isValidRegular breaks, but otherwise we could reduce overhead/complexity quite a bit by removing the indirection at parse time

@abiggerhammer
Copy link
Member

Try it out, run a benchmark, and send a PR? I'm happy to include speed improvements, but those are farther down the road for us -- right now we're focused on platform compat and debugging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants