feat(TresCanvas): add dpr prop #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tresjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alvarosabu
approved these changes
Jul 12, 2024
|
You are awesome @andretchen0 |
|
just FYI, is missing on the docs https://docs.tresjs.org/api/tres-canvas.html |
|
Left a new comment on the main thread #765 so i easier to track |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Tres sets the renderer's
pixelRatioautomatically, but doesn't allow the developer to specify or influence the value.Solution
Add a
:dprprop to<TresCanvas />that:number: overriding the system'spixelRatio.[number, number], clamping the system'spixelRatiobetween the first (expected min) and second (expected max) values.Playground
Playground demo added at:
http://localhost:5173/advanced/device-pixel-ratio
Meta
closes #765