v20.1.0-rc1

[fballiano]

Highlights

This is a big release, that's why we decided to move away from the 20.0.x versioning and go to 20.1.x. Since a lot of changes could have some impact on current installations we decided to release some "rc" versions before the official 20.1.0. Tests are more than welcome now but be extra careful with production environment.

What's most important is the removal of all the 3rd party libraries (phpseclib, mcrypt_compat, Cm_RedisSession, Cm_Cache_Backend_Redis and Pelago_Emogrifier and Zend Framework) form our repository, they are now imported via composer. This was an important step to clean up and modernise our code.

Also:

• the M1 legacy themes have been moved to an external repository since it's old (and mostly unused) code.
• a great improvement to EAV config cache has been added to v20.

Don't worry though, if you've always installed OpenMage extracting the zip file, starting from this release you'll find a new zip file attached to the release itself, we build this zip adding all of the old 3rd party libraries so that you will not have to migrate to composer or use composer at all.

Changelog

• Everything included in https://github.com/OpenMage/magento-lts/releases/tag/v19.5.0-rc1
• Remove legacy media uploader / editor remnants by @justinbeaty in Remove legacy media uploader / editor remnants #2434
• Remove more Internet Explorer code by @justinbeaty in Remove more Internet Explorer code #2427
• EAV Config Cache by @davidhiendl in EAV Config Cache #2993

New Contributors

• @davidhiendl made their first contribution in EAV Config Cache #2993

Full Changelog: v20.0.18...v20.1.0-rc1

---

This discussion was created from the release v20.1.0-rc1.

[luigifab]

There is a problem (with 20.1.0-rc1 or current rc2 from git), configurable products does not work any more (I think).
When I try to save a new configurable product from backend, I have the following error:

Notice: Object of class Mage_Catalog_Model_Resource_Eav_Attribute could not be converted to int
  in app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php on line 77

#1 app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php(77): in_array()
#2 app/code/core/Mage/Adminhtml/Block/Widget/Form.php(138): Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Super_Config_Simple->_prepareForm()
#3 app/code/core/Mage/Core/Block/Abstract.php(932): Mage_Adminhtml_Block_Widget_Form->_beforeToHtml()
#4 app/code/core/Mage/Core/Block/Abstract.php(650): Mage_Core_Block_Abstract->toHtml()
#5 app/code/core/Mage/Core/Block/Abstract.php(594): Mage_Core_Block_Abstract->_getChildHtml()
#6 app/design/adminhtml/default/default/template/catalog/product/edit/super/config.phtml(42): Mage_Core_Block_Abstract->getChildHtml()
#7 app/code/core/Mage/Core/Block/Template.php(257): include('...')
#8 app/code/core/Mage/Core/Block/Template.php(294): Mage_Core_Block_Template->fetchView()
#9 app/code/core/Mage/Core/Block/Template.php(307): Mage_Core_Block_Template->renderView()
#10 app/code/core/Mage/Adminhtml/Block/Template.php(74): Mage_Core_Block_Template->_toHtml()
#11 app/code/core/Mage/Core/Block/Abstract.php(933): Mage_Adminhtml_Block_Template->_toHtml()
#12 app/code/core/Mage/Adminhtml/Block/Widget/Tabs.php(399): Mage_Core_Block_Abstract->toHtml()
#13 app/design/adminhtml/default/default/template/widget/tabs.phtml(38): Mage_Adminhtml_Block_Widget_Tabs->getTabContent()
#14 app/code/core/Mage/Core/Block/Template.php(257): include('...')
#15 app/code/core/Mage/Core/Block/Template.php(294): Mage_Core_Block_Template->fetchView()
#16 app/code/core/Mage/Core/Block/Template.php(307): Mage_Core_Block_Template->renderView()
#17 app/code/core/Mage/Adminhtml/Block/Template.php(74): Mage_Core_Block_Template->_toHtml()
#18 app/code/core/Mage/Core/Block/Abstract.php(933): Mage_Adminhtml_Block_Template->_toHtml()
#19 app/code/core/Mage/Core/Block/Text/List.php(42): Mage_Core_Block_Abstract->toHtml()
#20 app/code/core/Mage/Core/Block/Abstract.php(933): Mage_Core_Block_Text_List->_toHtml()
#21 app/code/core/Mage/Core/Block/Abstract.php(650): Mage_Core_Block_Abstract->toHtml()
#22 app/code/core/Mage/Core/Block/Abstract.php(594): Mage_Core_Block_Abstract->_getChildHtml()
#23 app/design/adminhtml/default/default/template/page.phtml(53): Mage_Core_Block_Abstract->getChildHtml()
#24 app/code/core/Mage/Core/Block/Template.php(257): include('...')
#25 app/code/core/Mage/Core/Block/Template.php(294): Mage_Core_Block_Template->fetchView()
#26 app/code/core/Mage/Core/Block/Template.php(307): Mage_Core_Block_Template->renderView()
#27 app/code/core/Mage/Adminhtml/Block/Template.php(74): Mage_Core_Block_Template->_toHtml()
#28 app/code/core/Mage/Core/Block/Abstract.php(933): Mage_Adminhtml_Block_Template->_toHtml()
#29 app/code/core/Mage/Core/Model/Layout.php(580): Mage_Core_Block_Abstract->toHtml()
#30 app/code/core/Mage/Core/Controller/Varien/Action.php(397): Mage_Core_Model_Layout->getOutput()
#31 app/code/core/Mage/Adminhtml/controllers/Catalog/ProductController.php(291): Mage_Core_Controller_Varien_Action->renderLayout()
#32 app/code/core/Mage/Core/Controller/Varien/Action.php(428): Mage_Adminhtml_Catalog_ProductController->editAction()
#33 app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(262): Mage_Core_Controller_Varien_Action->dispatch()
#34 app/code/core/Mage/Core/Controller/Varien/Front.php(188): Mage_Core_Controller_Varien_Router_Standard->match()
#35 app/code/core/Mage/Core/Model/App.php(371): Mage_Core_Controller_Varien_Front->dispatch()
#36 app/Mage.php(740): Mage_Core_Model_App->run()
#37 index.php(62): Mage::run()

The configurable product is saved, but I can't access to it from backend.

[luigifab]

I added $usedAttributesIds = array_keys($usedAttributes); after $usedAttributes = and I use it line 77.
It seems that it fix the problem here.

[fballiano]

did you also try agains branch 20.0 today? since a few PRs were merged only on 20.0?

[fballiano]

on a 20.0 branch I tested now and I can create new configurables, dunno if this helps

[luigifab]

No, the error is still here with latest commit and 20.1.0-rc2 (for me).
Yes you can create, but you can go back to the product edit page.

[luigifab]

Fixed by #3182.

[TangLiang]

There is big problem,when add 2 or more store view,the problem will come up,i test many times,first i think it's the database problem,so i install with empty DB.everything works well,but when you add more store views,you can't create customers、orders on backend.blow are the error message.

2023-03-13T16:04:49+00:00 ERR (3): 
Exception: Cannot call addStoreLabel for different store views on the same collection in web/app/code/core/Mage/Eav/Model/Resource/Entity/Attribute/Collection.php:441
Stack trace:
#0 web/app/code/core/Mage/Eav/Model/Config.php(213): Mage_Eav_Model_Resource_Entity_Attribute_Collection->addStoreLabel(1)
#1 web/app/code/core/Mage/Eav/Model/Config.php(172): Mage_Eav_Model_Config->_loadEntityAttributes(Object(Mage_Eav_Model_Entity_Type), 1)
#2 web/app/code/core/Mage/Eav/Model/Config.php(532): Mage_Eav_Model_Config->_initializeStore(1)
#3 web/app/code/core/Mage/Eav/Model/Entity/Abstract.php(503): Mage_Eav_Model_Config->getEntityAttributeCodes(Object(Mage_Eav_Model_Entity_Type), Object(Mage_Customer_Model_Customer))
#4 web/app/code/core/Mage/Eav/Model/Entity/Abstract.php(938): Mage_Eav_Model_Entity_Abstract->loadAllAttributes(Object(Mage_Customer_Model_Customer))
#5 web/app/code/core/Mage/Core/Model/Abstract.php(292): Mage_Eav_Model_Entity_Abstract->load(Object(Mage_Customer_Model_Customer), 1, NULL)
#6 web/app/code/core/Mage/Adminhtml/Model/Session/Quote.php(138): Mage_Core_Model_Abstract->load(1)
#7 web/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Abstract.php(68): Mage_Adminhtml_Model_Session_Quote->getCustomer()
#8 web/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Header.php(48): Mage_Adminhtml_Block_Sales_Order_Create_Abstract->getCustomer()
#9 web/app/code/core/Mage/Core/Block/Abstract.php(933): Mage_Adminhtml_Block_Sales_Order_Create_Header->_toHtml()
#10 web/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create.php(93): Mage_Core_Block_Abstract->toHtml()
#11 web/app/design/adminhtml/default/default/template/widget/form/container.phtml(29): Mage_Adminhtml_Block_Sales_Order_Create->getHeaderHtml()
#12 web/app/code/core/Mage/Core/Block/Template.php(257): include('/home/wwwroot/l...')
#13 web/app/code/core/Mage/Core/Block/Template.php(294): Mage_Core_Block_Template->fetchView('adminhtml/defau...')
#14 web/app/code/core/Mage/Core/Block/Template.php(307): Mage_Core_Block_Template->renderView()
#15 web/app/code/core/Mage/Adminhtml/Block/Template.php(74): Mage_Core_Block_Template->_toHtml()
#16 web/app/code/core/Mage/Adminhtml/Block/Widget/Container.php(300): Mage_Adminhtml_Block_Template->_toHtml()
#17 web/app/code/core/Mage/Core/Block/Abstract.php(933): Mage_Adminhtml_Block_Widget_Container->_toHtml()
#18 web/app/code/core/Mage/Core/Block/Abstract.php(650): Mage_Core_Block_Abstract->toHtml()
#19 web/app/code/core/Mage/Core/Block/Abstract.php(594): Mage_Core_Block_Abstract->_getChildHtml('content', true)
#20 web/app/design/adminhtml/default/default/template/page.phtml(69): Mage_Core_Block_Abstract->getChildHtml('content')
#21 web/app/code/core/Mage/Core/Block/Template.php(257): include('/home/wwwroot/l...')
#22 web/app/code/core/Mage/Core/Block/Template.php(294): Mage_Core_Block_Template->fetchView('adminhtml/defau...')
#23 web/app/code/core/Mage/Core/Block/Template.php(307): Mage_Core_Block_Template->renderView()
#24 web/app/code/core/Mage/Adminhtml/Block/Template.php(74): Mage_Core_Block_Template->_toHtml()
#25 web/app/code/core/Mage/Core/Block/Abstract.php(933): Mage_Adminhtml_Block_Template->_toHtml()
#26 web/app/code/core/Mage/Core/Model/Layout.php(580): Mage_Core_Block_Abstract->toHtml()
#27 web/app/code/core/Mage/Core/Controller/Varien/Action.php(397): Mage_Core_Model_Layout->getOutput()
#28 web/app/code/core/Mage/Adminhtml/controllers/Sales/Order/CreateController.php(344): Mage_Core_Controller_Varien_Action->renderLayout()
#29 web/app/code/core/Mage/Core/Controller/Varien/Action.php(428): Mage_Adminhtml_Sales_Order_CreateController->indexAction()
#30 web/app/code/core/Mage/Core/Controller/Varien/Router/Standard.php(262): Mage_Core_Controller_Varien_Action->dispatch('index')
#31 web/app/code/core/Mage/Core/Controller/Varien/Front.php(188): Mage_Core_Controller_Varien_Router_Standard->match(Object(Mage_Core_Controller_Request_Http))
#32 web/app/code/core/Mage/Core/Model/App.php(371): Mage_Core_Controller_Varien_Front->dispatch()
#33 web/app/Mage.php(745): Mage_Core_Model_App->run(Array)
#34 web/index.php(62): Mage::run('', 'store')

compare with the v20.0.20

public function addStoreLabel($storeId)
    {
        // if not called previously
        if ($this->_addedStoreLabelsFlag === false) {
            $adapter = $this->getConnection();
            $joinExpression = $adapter
                ->quoteInto('al.attribute_id = main_table.attribute_id AND al.store_id = ?', (int)$storeId);
            $this->getSelect()->joinLeft(
                ['al' => $this->getTable('eav/attribute_label')],
                $joinExpression,
                ['store_label' => $adapter->getIfNullSql('al.value', 'main_table.frontend_label')]
            );
            $this->_addedStoreLabelsFlag = $storeId;
        } // check that previous call $storeId matches current call
        elseif ($this->_addedStoreLabelsFlag !== $storeId) {
            throw new Exception('Cannot call addStoreLabel for different store views on the same collection');
        }

        return $this;
    }

public function addStoreLabel($storeId)
    {
        $adapter        = $this->getConnection();
        $joinExpression = $adapter
            ->quoteInto('al.attribute_id = main_table.attribute_id AND al.store_id = ?', (int) $storeId);
        $this->getSelect()->joinLeft(
            ['al' => $this->getTable('eav/attribute_label')],
            $joinExpression,
            ['store_label' => $adapter->getIfNullSql('al.value', 'main_table.frontend_label')]
        );

        return $this;
    }
```````````````````

[davidhiendl]

This should be fixed with #3044 as well. The behavior of the addStoreLabel method did not really change, it just throws a proper error instead of a more different to trace SQL exception. If you test against the latest 20.x branch it should work.

[luigifab]

Fix included in rc2.

[davidhiendl]

@luigifab Does that mean "it works now" or "fix is included but still doesn't" ?

[luigifab]

Yes it works now. No new/other problems for me. Fixed by #3044.

[luigifab]

With the update of Redis modules, I rarely get: Error cleaning cache by mode matchingAnyTag: A pipeline is already in use and only one pipeline is supported. when I flush the cache.

See issue here.
Not sure if it's only me or not.

[luigifab]

@fballiano ready for rc3? there are tons of changes.

[fballiano]

@luigifab just released it! :-)