fix: Return error as sent from the UI instead of throwing a new one #4610
Conversation
| @@ -521,10 +519,10 @@ describe('SignatureController', () => { | |||
| it('throws if approval rejected', async () => { | |||
| messengerMock.call | |||
| .mockResolvedValueOnce({}) // LoggerController:add | |||
| .mockRejectedValueOnce({}); // ApprovalController:addRequest | |||
| .mockRejectedValueOnce({ message: 'User rejected the request.' }); // ApprovalController:addRequest | |||
There was a problem hiding this comment.
since we are mocking the request, how do we ensure 'User rejected the request.' is still being thrown?
There was a problem hiding this comment.
We only ensure whatever error was thrown by the client is returned as is. It is the responsibility of the client/UI in this case to throw the right error.
| @@ -432,7 +431,7 @@ export class SignatureController extends BaseController< | |||
| ); | |||
|
|
|||
| resultCallbacks = acceptResult.resultCallbacks; | |||
| } catch { | |||
| } catch (e) { | |||
There was a problem hiding this comment.
Very minor, but I think we try and avoid abbreviation so this could also be error.
| @@ -533,7 +531,6 @@ describe('SignatureController', () => { | |||
| { parseJsonData: true }, | |||
| ), | |||
| ); | |||
| expect(error instanceof EthereumProviderError).toBe(true); | |||
| expect(error.message).toBe('User rejected the request.'); | |||
There was a problem hiding this comment.
For extra stability, is there value in including a data property in the thrown error also, to ensure that too is thrown unaltered?
| @@ -40,7 +40,6 @@ import { | |||
| PersonalMessageManager, | |||
| TypedMessageManager, | |||
| } from '@metamask/message-manager'; | |||
| import { providerErrors } from '@metamask/rpc-errors'; | |||
There was a problem hiding this comment.
Is there anymore references to this package or can we remove @metamask/rpc-errors from package.json?
|
@metamaskbot publish-preview |
Explanation
When signatures are rejected the UI sends some extra information in the error data property. This information is stripped off when the error is re-thrown in the controller. This change aims as throwing the error back to the UI as received.
Removes the @metamask/rpc-errors package from the Signature controller as this is not used anymore.
References
Changelog
None
Checklist