Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyword parameters ineffective #55

Open
jonschumacher opened this issue May 16, 2023 · 2 comments · May be fixed by #100
Open

Keyword parameters ineffective #55

jonschumacher opened this issue May 16, 2023 · 2 comments · May be fixed by #100

Comments

@jonschumacher
Copy link
Member

Am I missing something or are the keyword parameters in

function load_tf_fromVNA(filename::String;
never used and thus the loaded TF is not really in the domain of the magnetic moment?

@tknopp
Copy link
Member

tknopp commented May 16, 2023

The code was originally developed by @mgraeser if I recall correctly.

@jusack
Copy link
Contributor

jusack commented May 16, 2023

I am currently changing the TransferFunction code (see #54), so we could definitely include that fix in there. It really looks like the R, N and A don't get used there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants