Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future: use @testsetup to reduce time to run tests on GPU #414

Closed
rkierulf opened this issue Jun 20, 2024 · 1 comment
Closed

Future: use @testsetup to reduce time to run tests on GPU #414

rkierulf opened this issue Jun 20, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@rkierulf
Copy link
Collaborator

Feature Request

For the Buildkite CI set up in #411 , we are currently calling Pkg.add("") in each test item for whichever GPU backend we are testing. This is to avoid having all four backends as a dependency in test/Project.toml, and the Pkg.add() step must be done in each test because of the way TestItemRunner.jl runs test items in separate modules.

However, calling Pkg.add() each time a test item is run introduces overhead that could possibly be avoided. It looks like there is a @testsetup macro under development (julia-vscode/TestItemRunner.jl#71) which would allow only adding the packages once, so we should look into using this once it is complete.

@rkierulf rkierulf added the enhancement New feature or request label Jun 20, 2024
@rkierulf
Copy link
Collaborator Author

Update: The previous approach of calling Pkg.add() in the middle of the tests led to some version dependency issues. We are now doing something closer to DiffEqGPUs approach here: https://github.com/SciML/DiffEqGPU.jl/blob/master/.buildkite/runtests.yml, so the overhead mentioned above with running the tests is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant