Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Recommend "type" #68

Open
brettz9 opened this issue Apr 30, 2020 · 0 comments
Open

🚀 Feature: Recommend "type" #68

brettz9 opened this issue Apr 30, 2020 · 0 comments
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@brettz9
Copy link

brettz9 commented Apr 30, 2020

Per https://nodejs.org/api/esm.html#esm_package_json_type_field

Package authors should include the "type" field, even in packages where all sources are CommonJS. Being explicit about the type of the package will future-proof the package in case the default type of Node.js ever changes, and it will also make things easier for build tools and loaders to determine how the files in the package should be interpreted.

It could also be checked for the valid values "commonjs" or "module".

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀 labels Mar 28, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Recommend "type" 🚀 Feature: Recommend "type" Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Development

No branches or pull requests

2 participants