Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Check for weird built-in node modules #54

Open
pdehaan opened this issue Aug 28, 2016 · 0 comments
Open

🚀 Feature: Check for weird built-in node modules #54

pdehaan opened this issue Aug 28, 2016 · 0 comments
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀

Comments

@pdehaan
Copy link
Contributor

pdehaan commented Aug 28, 2016

I've seen a ton of modules that specify fs and path in their dependencies.
http://npm.im/fs

It may be a bit hacky, but you could possibly store an array of built-in Node modules from https://nodejs.org/dist/latest-v6.x/docs/api/ (ie: "assert", "buffer", "child_process", "fs", "http", "path", etc) and then display warnings if the package.json uses any of those built-in modules.

Of course, there may be a valid reason to use the npm version of "path", so I guess they shouldn't be fatal errors, but I find most people may do npm i fs path -S by mistake and often don't want them or understand they have been built-in since Node 0.1. 🤷

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request 🚀 status: accepting prs Please, send a pull request to resolve this! 🙏 labels Mar 28, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Check for weird built-in node modules 🚀 Feature: Check for weird built-in node modules Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New enhancement or request 🚀
Projects
None yet
Development

No branches or pull requests

2 participants