Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Local path dependencies not recognized #38

Open
gramergrater opened this issue Nov 18, 2014 · 2 comments
Open

🐛 Bug: Local path dependencies not recognized #38

gramergrater opened this issue Nov 18, 2014 · 2 comments
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛

Comments

@gramergrater
Copy link

Example input:

{
  "name": "test",
  "version": "1.0.0",
  "author": "test",
  "devDependencies": {
    "test": "file:./"
  }
}

Expected result:

{
  "valid": true
}

Actual result:

{
  "valid": false,
  "errors": [
    "Invalid version range for dependency test: file:./"
  ]
}
@Mouvedia
Copy link

@gorillamania Shouldn't c15171c be cherrypicked?

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( 🐛 status: accepting prs Please, send a pull request to resolve this! 🙏 labels Mar 28, 2024
@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 28, 2024

Note that c15171c is against a pretty old fork of this repo, and would have merge conflicts trying to land now. The intent is good though - accepting PRs!

Per https://docs.npmjs.com/cli/v10/configuring-npm/package-json#local-paths, file: dependencies are allowed in npm.

Related: #71, for npm:, workspace:, and similar.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Local path dependencies not recognized 🐛 Bug: Local path dependencies not recognized Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛
Projects
None yet
Development

No branches or pull requests

3 participants