Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the unit test in ACSTest need to update #11734

Open
2 tasks done
leaf-soba opened this issue Sep 9, 2024 · 2 comments
Open
2 tasks done

the unit test in ACSTest need to update #11734

leaf-soba opened this issue Sep 9, 2024 · 2 comments
Labels
fetcher tests Related to tests

Comments

@leaf-soba
Copy link
Contributor

leaf-soba commented Sep 9, 2024

JabRef version

5.15 (latest release)

Operating system

macOS

Details on version and operating system

No response

Checked with the latest development build (copy version output from About dialog)

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. run unit test method findByDOI in ACSTest
  • failed reason:the link of this case https://pubs.acs.org/doi/pdf/10.1021/bk-2006-STYG.ch014 become "Page Not Found"
    2024-09-09 15 16 59
  1. I checked all elements in another page but it don't have element a.button_primary, which is used in org.jabref.logic.importer.fetcher.ACS to find Fulltext PDF, maybe it need fix to use another method to check whether Fulltext PDF exists or not.

Appendix

...

Log File
Paste an excerpt of your log file here
@Siedlerchr
Copy link
Member

@koppor You already took a look at the AcsFetcher, right?

@Siedlerchr Siedlerchr added fetcher tests Related to tests labels Sep 9, 2024
@koppor
Copy link
Member

koppor commented Sep 9, 2024

Yes, used to try other scraping frameworks. See commits at koppor#695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher tests Related to tests
Projects
None yet
Development

No branches or pull requests

3 participants