Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Update Loading spinner "Loading results..." to use translation utility #1937

Open
rylew1 opened this issue May 6, 2024 · 1 comment · May be fixed by #2186
Open

[Task]: Update Loading spinner "Loading results..." to use translation utility #1937

rylew1 opened this issue May 6, 2024 · 1 comment · May be fixed by #2186
Assignees
@mdragon
Labels
project: grants.gov Grants.gov Modernization tickets
Milestone
Search UI - Enhan...

Comments

@rylew1
Copy link
Contributor

rylew1 commented May 6, 2024 •
edited
Loading

Right now the loading spinner (/app/search/loading.tsx) work was done in parallel with the next-intl translation work and therefore didn't use the t() function with a translation string.

Acceptance criteria

  • Loader is using translation utility
@rylew1 rylew1 added the project: grants.gov Grants.gov Modernization tickets label May 6, 2024
@acouch
Copy link
Collaborator

acouch commented Sep 20, 2024

The component has moved but the translation still not addressed: https://github.com/HHS/simpler-grants-gov/blob/main/frontend/src/app/%5Blocale%5D/search/loading.tsx#L11

@mdragon mdragon self-assigned this Sep 20, 2024
mdragon added a commit that referenced this issue Sep 20, 2024
@mdragon
Add translation support to the search loading component. Adds potenti…
7316673 
…al for non-search loading translation as well

Fixes #1937
@mdragon mdragon linked a pull request Sep 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdragon mdragon

Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler Grants Sprint Planning
Status: Icebox
Milestone
Search UI - Enhancements and fast follow
Development

Successfully merging a pull request may close this issue.

[Issue #1937] Translate Loading component text HHS/simpler-grants-gov
3 participants
@mdragon @acouch @rylew1