[Task]: Add a pa11y ci step to spin up the API so it shows search results #2147
Comments
|
Migrated from navapbc#74 (comment) I think we actually want to test against both the red error state, and valid search results state. |
acouch
pushed a commit
to navapbc/simpler-grants-gov
that referenced
this issue
Sep 18, 2024
Fixes #{74}
> Added API setup to PA11y
> Updated Pa11y runtime to enable FF for search
> FF requirement was discovered with Ryan while exploring feature. Will
enable the search page for proper testing
> • svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
• svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
>Two new errors found now that API results are loading.
acouch
pushed a commit
to navapbc/simpler-grants-gov
that referenced
this issue
Sep 18, 2024
Fixes #{74}
> Added API setup to PA11y
> Updated Pa11y runtime to enable FF for search
> FF requirement was discovered with Ryan while exploring feature. Will
enable the search page for proper testing
> • svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
• svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
>Two new errors found now that API results are loading.
acouch
pushed a commit
that referenced
this issue
Sep 18, 2024
Fixes #{74}
> Added API setup to PA11y
> Updated Pa11y runtime to enable FF for search
> FF requirement was discovered with Ryan while exploring feature. Will
enable the search page for proper testing
> • svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
• svg elements with an img role have an alternative text
(https://dequeuniversity.com/rules/axe/4.2/svg-img-alt?application=axeAPI)
(html)
<html lang="en"><head><meta charset="utf-8"><me...</html>
>Two new errors found now that API results are loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Migrated from navapbc#74
Originally created by @rylew1 on Fri, 07 Jun 2024 16:46:34 GMT
blocked by #40
Summary
When pa11y tests the search page, it is doing so against just the frontend, and therefore the search page will not have any search results loaded (it will be just the red error alert) - but we want to a11y test against the actual search result list content.
ci-frontend-a11y.ymlshould add a step to load the API (see theci-frontend-e2e.ymlfile for how to do this - it should be the same exact process)Acceptance criteria
The text was updated successfully, but these errors were encountered: