Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting an unapproved Activity Report #147

Open
6 tasks
pamlo412 opened this issue Nov 11, 2020 · 5 comments
Open
6 tasks

Deleting an unapproved Activity Report #147

pamlo412 opened this issue Nov 11, 2020 · 5 comments
Labels
enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic JIRA Post MVP Issues cut from the MVP scope V1.0 MVP Indicates the release version for the issue

Comments

@pamlo412
Copy link
Contributor

pamlo412 commented Nov 11, 2020

User story:
As a TTA Specialist or a Specialist's manager, I want to be able to delete an activity report that was started mistakenly so that I don't have to see it in my to-do list forever.

Acceptance criteria:

  • Activity reports can only be deleted if they are not yet approved
  • the report can be deleted by:
    • a Smart Hub system admin
    • [ ]collaborators, authors or managers associated with the report.

  • the deletion process includes a warning message to confirm that the user is about to delete
  • once a report is deleted, a record of it remains in the database but nothing displays in the UI
  • a deleted report can be reinstated to the UI by a system admin

Design:
https://preview.uxpin.com/ad995fd722bd26c0f9a1c8a115f1b41833637308#/pages/134880467/simulate/no-panels?mode=i

Exclusions:

  • if multiple users (author, collaborators, and managers) have access to the report when one of them deletes it, there will be no notification to the others; it will simply disappear from their lists - see Notifications #157 (post MVP)
@pamlo412 pamlo412 added enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue labels Nov 11, 2020
@pamlo412 pamlo412 mentioned this issue Nov 18, 2020
@pamlo412
Copy link
Contributor Author

@PatricePascual-ACF I need your input on roles that can delete activity reports and on the acceptability of the user experience described in the exclusion item.

@PatricePascual-ACF
Copy link
Collaborator

@PatricePascual-ACF I need your input on roles that can delete activity reports and on the acceptability of the user experience described in the exclusion item.

Updated, with roles confirmed by Damon.

@pamlo412
Copy link
Contributor Author

Ready for grooming with team.

@pamlo412 pamlo412 added Post MVP Issues cut from the MVP scope Needs Design Flag to alert designer and removed Post MVP Issues cut from the MVP scope labels Nov 23, 2020
@matt-dobson
Copy link

@PatricePascual-ACF I wonder if there is a second story for the System Admin for the reinstatement of stories "a deleted report can be reinstated to the UI by a system admin"?

@matt-dobson
Copy link

@PatricePascual-ACF Also - if the Acceptance Criteria format of:
Acceptance Criteria:
“Given that I am a [type of user]
When I [take a specific action]
Then I [can do the desired action]”

Matches the Cucumber test syntax then it could likely kill two birds with one set of criteria.

@arickalewis1 arickalewis1 removed the Needs Design Flag to alert designer label Dec 18, 2020
@marriej marriej added the Post MVP Issues cut from the MVP scope label Jan 27, 2021
rahearn pushed a commit that referenced this issue Feb 5, 2021
…r-feedback

Document bin/run-tests, make sure frontend tests run in frontend instance
@marriej marriej added the JIRA label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic JIRA Post MVP Issues cut from the MVP scope V1.0 MVP Indicates the release version for the issue
Projects
None yet
Development

No branches or pull requests

5 participants