Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp GitHub review bot #53

Open
matthiasrohmer opened this issue Feb 20, 2023 · 2 comments
Open

Revamp GitHub review bot #53

matthiasrohmer opened this issue Feb 20, 2023 · 2 comments

Comments

@matthiasrohmer
Copy link
Collaborator

The former review bot based on a Glitch backend is currently broken, probably due to auth issues. Before fixing it, it might be good to outweigh wether moving to a GitHub action that can be shared for both web.dev and developer.chrome.com might be the better approach.

When doing this we should also re-evaluate the current set of rules, think about worthwhile additions (like enforcing thumbnail images for blog posts) and probably implement spell-checking (see GoogleChrome/developer.chrome.com#5354 (comment) for recommendations).

@matthiasrohmer
Copy link
Collaborator Author

One linting rule that would be good to have is to check for linking to failing hrefs. Also see GoogleChrome/developer.chrome.com#5496.

@mrienstra
Copy link

Former review bot is GoogleChromeLabs/chrome-devrel-review-bot, yeah? Must be, just ran across GoogleChromeLabs/chrome-devrel-review-bot#20

In terms of linting / formatting Markdown files, some options taken from oxsecurity/megalinter docs/descriptors/markdown.md:

PS: one of my motivations for suggesting linting / formatting Markdown: I had to "Save without Formatting" in VS Code to avoid making lots of spurious formatting changes when working on GoogleChrome/developer.chrome.com#5354. Surely I could turn off formatting for that repo somehow in VS Code, but it would be so much nicer to just have an official linter / formatter, so contributors don't have to examine several files to try to work out how things ought to be formatted before opening a PR. I didn't have to do that, but I've done it many times on other repos with inconsistent formatting, in an attempt to streamline the PR review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants