-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookie Settings Not Easily Discoverable #220
Comments
cc/ @chrisguindon if this has ever been flagged before, and if you have any thoughts on it. |
@brianking Thanks for indirectly reporting a bug! The badge should NOT be visible if we have a link to manage cookies on the page. I am currently working on a fix. Our solution is to hide the minimized badge if there is a link on the page to manage cookies. That link must include the .toolbar-manage-cookies class. |
@brianking We created a fix for this issue here: I hope to deploy this on www.eclipse.org later today. The following code will display the banner whenever someone clicks on an HTML element with the class .toolbar-manage-cookies: The open-vsx website will need to implement something similar if they wish to hide the badge. Our code assumes that the site has jQuery. This will need to be re-written if they are not using that framework. The badge is our fallback solution if the manage cookie link is missing from the page as we need to make sure that people can opt-out or opt-in at any time. Please let me know if you have any questions about this. |
Thanks Chris. I'll leave it in the hands of @spoenemann to decide if the fix can be taken here. |
@brianking Sounds good! This is now live on eclipse.org. |
I disabled the "Cookie settings" bar for now. Is it really necessary to allow users to revise their choice on cookies? |
Yes, users should be able to revoke at any time.
…On Wed, Dec 2, 2020 at 6:12 AM Miro Spönemann ***@***.***> wrote:
I disabled the "Cookie settings" bar for now. Is it really necessary to
allow users to revise their choice on cookies?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#220 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG2H5V2REN2FYJ6KJDVMB3SSYOI5ANCNFSM4TZ25YLQ>
.
--
Christopher Guindon
Manager, Web Development | Eclipse Foundation, Inc.
Eclipse Foundation: The Platform for Open Innovation and Collaboration
Twitter: @chrisguindon
|
Ok so from what I can see, a 'Manage Cookies' link is outstanding to add here. As the footer is already crowded, I propose we add it to the user menu similar to how eclipse.org does it. |
I agree. I think we should include it as we will probably want to add Google Analytics on the site to get some stats about how our users are using the site |
Hi, I can add an optional field in page settings for additional menu items to be rendered below the user name. So such a 'Manage Cookies' Button could be shown there, but only if the user is logged in. I guess the button should also be visible if the user is not logged in. I think about where to show the link in this case. To offer optional space to the right of the avatar (as it is almost on eclipse.org) is not a good solution in my eyes as there is no general need for such slots there. |
I talked with @spoenemann about it and we both think that the "Manage Cookies" Button would be best in footer. Since it is crowded as @brianking already mentioned we'd propose to generally hide some footer items in a dropdown (or is i called dropup in this case? :-) ) like it is for smaller window sizes. |
@spoenemann @brianking it seems as if I do not have the permission to push here. Can you fix that? Thanks! |
@jbicker From what I can tell, you do have write access to this repo. |
Ah yes, thanks. Works from local VSCode. Need authorization token for Gitpod. Anyway I created #394 as a draft. |
@jbicker This seems to work well on eclipse.org. You can't replicate that same behavior here? |
@autumnfound If you have time this week, can you take a look at helping @jbicker solve this issue. |
@linkfang can you please create a "Manage Cookies" link in the footer toolbar that triggers our cookie consent banner when clicked on? I believe the project is using our javascript script code. If so, you simply need to create a link with the class .toolbar-manage-cookies. |
@chrisguindon we need this first before we can get info on visitors and downloads, right? Do you want me to open a separate ticket for enabling the tracking? |
@kineticsquid Indeed. We need to allow users to revoke our cookie consent banner before we can enable Google Analytics for the site. +1 For creating a separate issue for installing GA. You can assign that one to me. |
Once you accept or decline cookies, the bar minimizes to below the Github logo and repository name in the footer on the bottom left. It appears to look like a design element of the footer, and it is not obvious that you should hover it it to expand it and click to launch.
I see it works the same way on eclipse.org, so it is by design. And the fix might not be here, but in the cookie module being used. However I thought I would call it out anyway.
The text was updated successfully, but these errors were encountered: