Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mindependency should rationalize updated dependencies against dev_requirements.txt #37450

Open
scbedd opened this issue Sep 18, 2024 · 0 comments
Assignees

Comments

@scbedd
Copy link
Member

scbedd commented Sep 18, 2024

With the newest merge of azure-core==1.31.0, we have begun to see a new mindependency failure across our pipelines.

Failure

The failure occurs when:

  • a given package has a dev_requirement on a local version of azure-identity...indicating a very NEW azure-identity
  • The given package has a direct dependency against azure-core

The issue is that the local-relative-path version of azure-identity requires azure-core>=1.31.0. When we resolve mindependencies for azure-core, we'll resolve some version of azure-core PRIOR to azure-core==1.31.0. On installation, we will fail.

To resolve this we need to make the following adjustments:

  • When grabbing the packages that will be the "minimum dependencies", we ALSO parse the requirements from these minimum dependencies
  • If a given requirement conflicts with a dev_requirement, we should remove the line with that conflicting dependency from the dev_requirement file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🤔 Triage
Development

No branches or pull requests

1 participant