Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certain response headers coming from AzurePipelinesCredential to be logged #37412

Open
ahsonkhan opened this issue Sep 16, 2024 · 0 comments
Assignees
Milestone

Comments

@ahsonkhan
Copy link
Member

These two response headers are useful for the service team to debug and diagnose issues, and hence it is requested that we do log them.

  • x-vss-e2eid
  • activityid

Given our logged headers are based on an allow list, currently these two headers are REDACTED.

DEFAULT_HEADERS_ALLOWLIST: Set[str] = set(
[
"x-ms-request-id",
"x-ms-client-request-id",
"x-ms-return-client-request-id",
"x-ms-error-code",
"traceparent",
"Accept",
"Cache-Control",
"Connection",
"Content-Length",
"Content-Type",
"Date",
"ETag",
"Expires",
"If-Match",
"If-Modified-Since",
"If-None-Match",
"If-Unmodified-Since",
"Last-Modified",
"Pragma",
"Request-Id",
"Retry-After",
"Server",
"Transfer-Encoding",
"User-Agent",
"WWW-Authenticate", # OAuth Challenge header.
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Not Started
Development

No branches or pull requests

3 participants