Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebPubSubClient::close emits unexpected warning #37390

Open
admindgard opened this issue Sep 13, 2024 · 2 comments
Open

WebPubSubClient::close emits unexpected warning #37390

admindgard opened this issue Sep 13, 2024 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. WebPubSub

Comments

@admindgard
Copy link

  • Package Name: azure-messaging-webpubsubclient
  • Package Version: 1.1.0, 1.0.1
  • Operating System: Mac
  • Python Version: 3.10

Describe the bug
When attempting to close the webpubsub client, a warning is emitted: "The client is stopping state. Stop recovery."

It's not clear that this warning is actionable, and I can't see any way to prevent it (other than leaving the connection open, or filtering logs).

To Reproduce
Steps to reproduce the behavior:

  1. create webpubsub client
  2. open connection
  3. (exchange messages)
  4. call client.close()

Similarly, via the context manager:

wps_url = "wss://xxxxx.webpubsub.azure.com/client/hubs/xxxxxx?access_token=xxxxxx"
credentials = WebPubSubClientCredential(client_access_url_provider=wps_url)
wps_client = WebPubSubClient(credential=credentials)
with wps_client:
    pass

Expected behavior
No warning message for happy-path usage.

@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-triage Workflow: This issue needs the team to triage. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that WebPubSub labels Sep 13, 2024
@xiangyan99 xiangyan99 added Service Attention Workflow: This issue is responsible by Azure service team. and removed needs-team-triage Workflow: This issue needs the team to triage. labels Sep 13, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 13, 2024
@xiangyan99
Copy link
Member

Thanks for the feedback, we’ll investigate asap.

@msyyc
Copy link
Member

msyyc commented Sep 14, 2024

Let me take an investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. WebPubSub
Projects
None yet
Development

No branches or pull requests

3 participants