Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Relative URLs break critical css generation #39455

Open
dilirity opened this issue Sep 19, 2024 · 1 comment
Open

Boost: Relative URLs break critical css generation #39455

dilirity opened this issue Sep 19, 2024 · 1 comment
Assignees
Labels
[Boost Feature] Cloud CSS [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress

Comments

@dilirity
Copy link
Member

dilirity commented Sep 19, 2024

p1726628647463949-slack-C016BBAFHHS

If a source provider has a relative URL, the URL constructor throws an error because it's an invalid URL and breaks the whole generation process. It shouldn't - it should probably show the error under advanced recommendation but it should not break the whole process.

The PHP side that makes sure a relative URL doesn't end up in the source providers will be handled in #39456.

We still need to update the UI to not show a fatal error if a malformed URL reaches critical css. In other words, handle exceptions when the URL is attempted to be created before passing it to the generator (or is it the css generator that throws the error?).

@dilirity dilirity added [Plugin] Boost A feature to speed up the site and improve performance. [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Boost Feature] Cloud CSS labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Cloud CSS [Boost Feature] Critical CSS Issues involving the Critical CSS feature in Boost [Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress
Projects
None yet
Development

No branches or pull requests

2 participants
@dilirity and others