Fatal error when $submenu is NULL for cetain user roles

[ecairol]

Impacted plugin

Jetpack, CRM

Quick summary

This error is happening for users with the role zerobs_admin (aka as Jetpack CRM Admin (Full CRM Permissions)), but I suspect it could happen to other custom user roles as well.

The error

PHP Fatal error: Uncaught TypeError: array_column(): Argument #1 ($array) must be of type array, null given in /wordpress/plugins/jetpack/13.9-a.3/jetpack_vendor/automattic/jetpack-masterbar/src/admin-menu/class-atomic-admin-menu.php:333
Stack trace:
#0 /wordpress/plugins/jetpack/13.9-a.3/jetpack_vendor/automattic/jetpack-masterbar/src/admin-menu/class-atomic-admin-menu.php(333): array_column(NULL, 3)
#1 /wordpress/plugins/jetpack/13.9-a.3/jetpack_vendor/automattic/jetpack-masterbar/src/admin-menu/class-admin-menu.php(40): Automattic\Jetpack\Masterbar\Atomic_Admin_Menu->add_jetpack_menu()
#2 /wordpress/plugins/jetpack/13.9-a.3/jetpack_vendor/automattic/jetpack-masterbar/src/admin-menu/class-atomic-admin-menu.php(76): Automattic\Jetpack\Masterbar\Admin_Menu->reregister_menu_items()
#3 /wordpress/core/6.6.2/wp-includes/class-wp-hook.php(324): Automattic\Jetpack\Masterbar\Atomic_Admin_Menu->reregister_menu_items('')
#4 /wordpress/core/6.6.2/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)
#5 /wordpress/core/6.6.2/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#6 /wordpress/core/6.6.2/wp-admin/includes/menu.php(161): do_action('admin_menu', '')
#7 /wordpress/core/6.6.2/wp-admin/menu.php(412): require_once('/wordpress/core...')
#8 /wordpress/core/6.6.2/wp-admin/admin.php(158): require('/wordpress/core...')
#9 /wordpress/core/6.6.2/wp-admin/index.php(10): require_once('/wordpress/core...')
#10 {main}
thrown in /wordpress/plugins/jetpack/13.9-a.3/jetpack_vendor/automattic/jetpack-masterbar/src/admin-menu/class-atomic-admin-menu.php on line 333

This is happening for all Jetpack CRM Admin users that login via SSO.

The bug was added back in March, when adding the Scan option to the Jetpack submenu:

Potential fix
Here's a potential fix to the problem: Pull Request #39424

Steps to reproduce

Team 51 can provide you access to the error logs on one of our partner's sites.

1. Login to the site as an Admin
2. Create a user with the role Jetpack CRM Admin
3. On another browser, try to login with this new user using SSO
4. The new user is unable to login, and sees: There has been a critical error on this website. Please check your site admin email inbox for instructions.

A clear and concise description of what you expected to happen.

No response

What actually happened

No response

Impact

Some (< 50%)

Available workarounds?

No and the platform is unusable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Atomic

Logs or notes

No response

[jartes]

📌 ACTIONS

• Triaged
• Lowered priority from Blocker to High.

📌 Message to Author
Thanks for reporting and proposing a PR for this one @ecairol!