Subscription block: it doesn't use the email I provide

[oandregal]

Impacted plugin

Jetpack

Quick summary

The subscription block doesn't take into account the email you introduced if you are logged in to WordPress.com

Steps to reproduce

1. Log in to your WordPress.com account with [email protected].
2. Go to a site that uses the subscription block (or create a test site).
3. Introduce an [email protected] in the subscription block and click "Subscribe".

The expectation is that YYY would be used as an email. Instead, what happened was that the WordPress.com account linked to the XXX was automatically subscribed.

A clear and concise description of what you expected to happen.

No response

What actually happened

No response

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

If Jetpack is going to use a different email for searching a WordPress.com account, it should be clear up-front. Perhaps the subscription block should display that logged-in WordPress.com account, or perhaps it should just use the email provided.

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

[mrfoxtalbot]

I can replicate this. I entered [email protected]:

...and the confirmation email showed [email protected]

This is ONLY happening on AT sites. On Simple sites and self-hosted sites using Jetpack, the email shows grayed out and the field is not editable.

[mrfoxtalbot]

It's very odd that it is only broken on AT sites.
I am keeping this as high-priority.

[oandregal]

This is ONLY happening on AT sites. On Simple sites and self-hosted sites using Jetpack, the email shows grayed out and the field is not editable.

Oh, interesting, I didn't know this. I may have another piece of information to share then:

I was actually responding to a forum request. According to the HTML, that site is probably using a jetpack legacy widget that wraps a jetpack block subscription. You can visit https://b2b-marketing.pl/ and see how it doesn't provide the uneditable grayed-out email field even if you're logged in to WordPress.com.

Trying in my own site (jetpack connected, uses the jetpack subscription form), I do see the email uneditable.

[github-actions]

Support References

This comment is automatically generated. Please do not edit it.

• https://wordpress.com/forums/topic/email-subscription-now-working-your-subscription-did-not-succeed
• 5695723-zen
• 5829671-zen
• 5924135-zen
• 8697299-zen

[m1r0]

I did an investigation and landed on this diff: D128616-code

It looks like this logic is overwriting the initial email when jwt_token is passed but I'm missing context why that is.

I'm EOD, so feel free to pick this up.

cc @chrismccluskey

[jeherve]

This was also reported in #39267:

5695723-zd-a8c
5829671-zd-a8c
5924135-zd-a8c
8697299-zd-a8c

[foleynotrose]

It's very odd that it is only broken on AT sites.

Are we certain? I observed the behavior on https://nonviolentleadership.com/, which has a Business subscription, but is not registering in our system as Atomic:

Pc9OEs-v-p2

Reported it in this other issue: #39267 (comment)

[heavyweight]

I created this diff to fix it D161772-code
However I'm a bit hesitant for possible regressions.

Can someone try it out?

[fushar]

The above diff tests well for me. However, I'm not 100% sure if it won't cause other issues, so it would be better if more relevant team reviews it as well 🤔