Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus trap in feed entry header #1424

Open
joeacarstairs opened this issue Jun 10, 2024 · 2 comments
Open

Focus trap in feed entry header #1424

joeacarstairs opened this issue Jun 10, 2024 · 2 comments

Comments

@joeacarstairs
Copy link

Describe the bug

There's a focus trap in the feed entry header component.

To Reproduce
Steps to reproduce the behavior:

  1. Open a CommaFeed client with at least one entry in the feed.
  2. Click on any entry in the feed.
  3. Press TAB repeatedly.

Expected behavior

You eventually escape the feed header.

Actual behaviour

You cycle between four elements indefinitely.

Screenshots

Focus trap

Environment (please complete the following information):

  • CommaFeed version (or "commafeed.com"): 4.4.0
  • Browser [e.g. chrome, firefox]: Firefox
  • Device [e.g. desktop, mobile]: Desktop

Additional context

@Athou
Copy link
Owner

Athou commented Jun 11, 2024

I have to admit I never used the tab key, there are a lot of keyboard shortcuts to navigate between entries. I can reproduce the issue but I don't know why it happens. It stops if I make either the header or the star and open link icons unfocusable (tabindex=-1), but I don't know if this is acceptable. May I ask how you use the tab key to navigate CommaFeed?

@Athou Athou added the bug label Jun 11, 2024
@joeacarstairs
Copy link
Author

I was also puzzled as to why this happens! I thought it was better to write it down anyway.

As for how I'm using CommaFeed: I like to go through a feed by marking each item as 'read' in sequence. I usually do this with the mouse, but I would prefer to do it with the keyboard. I know that the universal way to move between focusable elements in sequence on webpages is using the TAB key, so that's what I tried. Hope that's helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants