Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when SSND chunk's offset and blocksize are non-zero #37

Closed
AkiyukiOkayasu opened this issue Sep 11, 2023 · 1 comment
Closed

Panic when SSND chunk's offset and blocksize are non-zero #37

AkiyukiOkayasu opened this issue Sep 11, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AkiyukiOkayasu
Copy link
Owner

#33 (comment)

it doesn't seem to support offset and blocksize in the SSND chunk (those fields are rarely used so probably ok)

In most cases, this will not be a problem, but it should be handled appropriately.

pacmog/src/lib.rs

Lines 108 to 109 in cf65111

assert_eq!(ssnd_block_info.offset, 0); //offsetとblock_sizeはほとんどの場合で0固定。したがって0で指定されたファイルにのみ対応する。
assert_eq!(ssnd_block_info.block_size, 0);

@AkiyukiOkayasu AkiyukiOkayasu added the bug Something isn't working label Sep 11, 2023
@AkiyukiOkayasu
Copy link
Owner Author

Resolved in #52 .
But only not panic. offset and block_size of 0 are only supported.
This is because most AIFF files are typically 0 and there is little need to support them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant