Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartOperationParsing not called on subscriptions #903

Closed
jacksontj opened this issue Oct 16, 2019 · 4 comments
Closed

StartOperationParsing not called on subscriptions #903

jacksontj opened this issue Oct 16, 2019 · 4 comments
Labels
bug Something isn't working stale

Comments

@jacksontj
Copy link

What happened?

I enabled tracing on my gqlgen server which had a Subscription added to it. After doing so I immediately hit 99designs/gqlgen-contrib#10 -- which stems from the fact that StartOperationParsing is never called for Subscription calls. It seems that the websocket handler has its own query parsing (separate from the the on in graphql.go which starts the trace).

What did you expect?

I would expect that StartOperationParsing would still be called in subscriptions (since request parsing, etc. still happens).

@stale
Copy link

stale bot commented Dec 15, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 15, 2019
@jacksontj
Copy link
Author

This is still an issue, so it shouldn't be marked stale

@stale stale bot removed the stale label Dec 16, 2019
@vvakame
Copy link
Collaborator

vvakame commented Dec 25, 2019

We have a big change in #885 .
I think this issue will be fixed in master / HEAD.

@vvakame vvakame added the bug Something isn't working label Dec 25, 2019
@stale
Copy link

stale bot commented Feb 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 23, 2020
@stale stale bot closed this as completed Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

2 participants