Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket Error Handling during websocket upgrade #3213

Open
aleksey-korolev opened this issue Aug 9, 2024 · 0 comments
Open

Websocket Error Handling during websocket upgrade #3213

aleksey-korolev opened this issue Aug 9, 2024 · 0 comments

Comments

@aleksey-korolev
Copy link

What happened?

When an error happens during upgrade of websocket, there's no way to process such error in a custom way.

What did you expect?

#1975 added possibility to specify handler func for errors, but it gets called only for errors happening at a later stage. It would be nice to get it called during upgrade as well e.g. when Upgrader calls CheckOrigin and origins don't match or when the client hasn't specified correct Sec-Websocket-Version etc

versions

github.com/99designs/[email protected]
go1.19.1 darwin/amd64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant