Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel builds no longer work after landing #2988 #3181

Open
clayne11 opened this issue Jul 12, 2024 · 1 comment · May be fixed by #3182
Open

Bazel builds no longer work after landing #2988 #3181

clayne11 opened this issue Jul 12, 2024 · 1 comment · May be fixed by #3182

Comments

@clayne11
Copy link
Contributor

clayne11 commented Jul 12, 2024 •
edited
Loading

What happened?

Bazel builds no longer work, packages are not pulling in their types correctly after #2988 was landed.

What did you expect?

Bazel builds continue to work.

Minimal graphql.schema and models to reproduce

Cannot minimally reproduce this without an advanced Bazel setup.

If I revert this #2988, everything works as expected.

versions

  • go run github.com/99designs/gqlgen version? v0.17.49
  • go version? go1.22.5
@clayne11 clayne11 linked a pull request Jul 13, 2024 that will close this issue
Open
@StevenACoffman StevenACoffman mentioned this issue Jul 13, 2024
Open
@agratta-silo
Copy link
Contributor

Is this a problem with Bazel? I'm not familiar with Bazel, but it seems wrong that a third-party build tool should dictate how gqlgen should work internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "fix: stop loading package dependencies (#2988)" clayne11/gqlgen
2 participants
@clayne11 @agratta-silo