Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-vault 6.6.0 behavior change #889

Closed
1 of 3 tasks
chenrui333 opened this issue Mar 12, 2022 · 8 comments
Closed
1 of 3 tasks

aws-vault 6.6.0 behavior change #889

chenrui333 opened this issue Mar 12, 2022 · 8 comments
Labels

Comments

@chenrui333
Copy link

chenrui333 commented Mar 12, 2022

  • I am using the latest release of AWS Vault
  • I have provided my .aws/config (redacted if necessary)
  • I have provided the debug output using aws-vault --debug (redacted if necessary)

👋 trying to upgrade aws-vault to use the latest release, but ran into some issue as below the runtime behavior seems different between macOS and linux (for aws-vault login):

On macOS

$ aws-vault login
aws-vault: error: login: argument 'profile' not provided, nor any AWS env vars found. Try --help

On linux

/ # ./aws-vault login
aws-vault: error: Specified keyring backend not available, try --help

kind of relates to Homebrew/homebrew-core#96523

@mtibben
Copy link
Member

mtibben commented Mar 13, 2022

Hey @chenrui333 I'm struggling to understand what the issue is without further details.

Your macOS example returns an error because you have not specified a profile and aws env vars haven't been found. 6.5.0 behaviour also displayed an error for this.

Your Linux example returns an error because your selected keyring backend isn't available. You'll need to supply more information to show what backend you're using, and what the difference to 6.5.0 was, because 6.5.0 also would return an error when the selected backend wasn't available.

@SMillerDev
Copy link

Looking at the logs the different behaviour is that the command aws-vault login now complains about the selected keyring backend. Except it does not select any keyring backend that I can see.

@mtibben
Copy link
Member

mtibben commented Mar 14, 2022

Please provide details with --debug as the issue template requests

@SMillerDev
Copy link

$ /home/linuxbrew/.linuxbrew/Cellar/aws-vault/6.6.0/bin/aws-vault login --debug 2>&1
2022/03/14 08:19:28 aws-vault 6.6.0-Homebrew
2022/03/14 08:19:28 [keyring] Considering backends: [keyctl]
2022/03/14 08:19:28 [keyring] Failed backend keyctl: accessing "" keyring failed: unknown scope ""
aws-vault: error: Specified keyring backend not available, try --help

@mtibben
Copy link
Member

mtibben commented Mar 14, 2022

In v6.5.0, aws-vault login PROFILE - PROFILE is mandatory

in v6.6.0, aws-vault login [PROFILE] - PROFILE is optional.

Both v6.5.0 and v6.6.0 throw the same error when a profile argument is given

Why is homebrew testing the behaviour of an error message about missing arguments... i don't understand

@SMillerDev
Copy link

Why is homebrew testing the behaviour of an error message about missing arguments... i don't understand

Because we want to validate that it compiled and runs succesfully and any other check requires credentials.

Both v6.5.0 and v6.6.0 throw the same error when a profile argument is given

That's good to know, we can adjust the test to give an invalid profile.

@SMillerDev
Copy link

I created #890 since this issue has a bunch of unrelated information about Homebrew tests that aren't part of the problem.

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants