Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking same numeric hash link multiple times causes target element to scroll under menu #18

Open
Bilge opened this issue Mar 6, 2018 · 0 comments
Labels

Comments

@Bilge
Copy link
Member

Bilge commented Mar 6, 2018

Since scroll logic is only applied when the hash changes, clicking the same hash two or more times causes the scroll logic to revert to the browser default (because the hash is no longer changing). Does not apply to tracking links because they're invalid hashes anyway. Can be fixed by overriding hash links on the page.

Additionally, clicking a Top 250 label link does not scroll to the hash element properly, since the hash was set on page load rather than changing. This is no longer the case.

@Bilge Bilge added the bug label Mar 6, 2018
@Bilge Bilge changed the title Clicking the same numeric hash link twice in a row causes target element to scroll under menu Clicking same numeric hash link multiple times causes target element to scroll under menu Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant